Kithmaker Commander
 3926 Posts




 | | 03/15/2006 11:57 PM |
| | I just noticed that declined trades get moved to the "closed trades" section AND get counted in the total number of trades. Seems to me that the total number there should only be successful trades --- not also those that failed to go anywhere. | | My H/W list is not current... Trade Reference List OLD Trade references (191) | |
|
realmaster Underboss
 1960 Posts



 Home of the 2002 Winter Olympics
 | | 03/16/2006 12:07 AM |
| | I think that I was able to delete mine. Yours does not have this option? | | Thanks, realmaster. Let's split up!!!!!
RIP Gary Gygax 1938-2008
Unhallowed vindicated champion: van richten Successful trades:72 Trades in progress:0 Have issues with:1 burning_kazuki Bad trades:0 References: I have given up on creating a link down here so you will have to click the green shield on the left and I hope that it works for you. Sometimes it does not work for me. | |
|
 Lead Moderator LCS Underboss
 1867 Posts




 | | 03/16/2006 12:45 AM |
| I think that is only when you are viewing your own trades in the interface, since both completed and declined trades end up in the "closed" trades category.
When you look at someone else's trades the only categories are "open" trades and "completed" trades.
If a declined trade is showing up on someone else's trade list, then we have a problem.
| | | |
|
Kithmaker Commander
 3926 Posts




 | | 03/16/2006 1:27 AM |
| | No, I can delete them -- but if I don't it remains there and looks like I have more successful trades than I do (since others can only see "closed trades" which I think are assumed to be successful trades). So, what I'm saying is someone could leave declined trades in their "closed trades" section to look like a bunch of successful trades. | | My H/W list is not current... Trade Reference List OLD Trade references (191) | |
|
realmaster Underboss
 1960 Posts



 Home of the 2002 Winter Olympics
 | | 03/16/2006 2:01 AM |
| quote: Originally posted by Kithmaker
No, I can delete them -- but if I don't it remains there and looks like I have more successful trades than I do (since others can only see "closed trades" which I think are assumed to be successful trades). So, what I'm saying is someone could leave declined trades in their "closed trades" section to look like a bunch of successful trades.
When I look through your trades I can only see the accepted trades and not the declined ones. | | Thanks, realmaster. Let's split up!!!!!
RIP Gary Gygax 1938-2008
Unhallowed vindicated champion: van richten Successful trades:72 Trades in progress:0 Have issues with:1 burning_kazuki Bad trades:0 References: I have given up on creating a link down here so you will have to click the green shield on the left and I hope that it works for you. Sometimes it does not work for me. | |
|
 Lead Moderator LCS Underboss
 1867 Posts




 | | 03/16/2006 2:20 AM |
| quote: Originally posted by Kithmaker
(since others can only see "closed trades" which I think are assumed to be successful trades)
When other people look at your list, they don't see "closed" trades, they only see "completed" trades. The categories are different depending on whether you are looking at your own trade page or a different user's trade page.
So if someone leaves a lot of declined trades in their "closed" trades, they are only fooling themselves, since everyone else only sees however few "completed" trades they have.
I do think it would be a good idea to have a separate category for declined trades (offered or received) when viewing your own trade page , just to avoid the confusion though.
| | | |
|
The Mighty jai Commander
 3235 Posts



 | | 03/16/2006 9:22 AM |
| Kithmaker, how many trades should you have? I am seeing 10 open, 10 completed, and 114 priors. | | | |
|
Kithmaker Commander
 3926 Posts




 | | 03/16/2006 10:37 AM |
| LCS and realmaster -- how do you guys know that you're looking at my completed trades and not declined ones? I don't know that when I look at other people's trades.
And, "closed" = "completed" when I'm talking here. I didn't have the trade page open for reference. What I'm saying is that, at least when I'm viewing my own trades, declined and successfully completed trades get put in the same area and are counted toward my total of completed trades (last night, it was 11 because I had an offer declined. I deleted it, so now it's 10).
I should now be showing 10 open and 10 completed. But I don't have any declined ones sitting there right now. I should have left that one so I could test this with other users.
| | My H/W list is not current... Trade Reference List OLD Trade references (191) | |
|
 Lead Moderator LCS Underboss
 1867 Posts




 | | 03/16/2006 7:22 PM |
| quote: Originally posted by Kithmaker
And, "closed" = "completed" when I'm talking here.
The code that Jai wrote for the trade interface does know that "closed" does not equal "completed", or at least it did a while back and hopefully still does.
The declined trades that show up in the "closed" category when you look at your trades should not be showing up in the "completed" trades that other people see when they look at your trades.
If you want to prove this to yourself, I've sent you an offer for testing purposes.
If you look at my trade page before you decline the trade, it should show 2+ open trades and 18 completed.
If you look again after you decline the trade, it should show one less open trade, and still 18 completed.
| | | |
|
Kithmaker Commander
 3926 Posts




 | |
realmaster Underboss
 1960 Posts



 Home of the 2002 Winter Olympics
 | | 03/17/2006 12:03 AM |
| | When I go through and look through your completed trades they all say accepted not declined. | | Thanks, realmaster. Let's split up!!!!!
RIP Gary Gygax 1938-2008
Unhallowed vindicated champion: van richten Successful trades:72 Trades in progress:0 Have issues with:1 burning_kazuki Bad trades:0 References: I have given up on creating a link down here so you will have to click the green shield on the left and I hope that it works for you. Sometimes it does not work for me. | |
|
The Mighty jai Commander
 3235 Posts



 | | 03/17/2006 9:21 AM |
| | So everything here is green? | | | |
|
Kithmaker Commander
 3926 Posts




 | |